ci: bump actions/checkout to v7 - #3
Merged
Merged
Conversation
The first CI run on main warned that actions/checkout@v4 targets Node.js 20 and is being force-run on Node 24. v5 onward all ship `using: node24`; v7.0.1 is the current stable major. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PfAfAujueuZ3rDTiL9apx3
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe CI workflow updates the checkout action from ChangesCI checkout action update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 29: Update both actions/checkout@v7 steps in the CI workflow to set
persist-credentials to false, unless either checkout is followed by a step that
explicitly requires authenticated Git operations.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8fe47d90-4467-43ae-8ef2-91ed21563073
📒 Files selected for processing (1)
.github/workflows/ci.yml
checkout defaults to persist-credentials: true, which leaves the job token in .git/config where it can escape through uploaded artifacts (the "artipacked" class; flagged by zizmor via CodeRabbit). Neither job does authenticated git work — they install a toolchain and run cargo — so persisting the credential is exposure with no upside. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PfAfAujueuZ3rDTiL9apx3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first CI run on
mainemitted a deprecation annotation on both test jobs:Bumps to
actions/checkout@v7. Verified against the upstream repo rather than assumed — v5.1.0, v6.1.0, and v7.0.1 all declareusing: node24, so any would clear the warning; v7.0.1 is the current stable major.Expected result: the same three green jobs with no deprecation annotation.
Post-Deploy Monitoring & Validation
Watch this PR's run for the absence of the Node 20 annotation, with all three jobs still green and 91 tests per runner. No runtime or production impact — CI configuration only.
Summary by CodeRabbit